0000099: Corrupt packets are sent when RPM interrupts are active

(0000155)
Fred (administrator)
2009-02-22 16:41

The issue is with either my Nippon Denso code, OR the ignition or fuel code. I tried to reproduce the issue with Phil's 36-1 decoder and could not. Most likely the ignition PIT code is broken and corrupting memory. I will try to disable this next.

(0000156)
Fred (administrator)
2009-02-22 16:52

Removing the ignition code did not help, I'll have to try removing the fuel code and putting ignition back. Then I'll remove both. If it still occurs then I'll look for the reason why it is happening in the remaining code. If that stops it I'll put a sleep function in to see if it is a sheer run time thing.

(0000157)
Fred (administrator)
2009-02-22 17:26

Removal of fuel code didn't help either. ADC sampling is next to go.

(0000158)
Fred (administrator)
2009-02-22 17:48

ADC sampling based on memcpy() is the cause!! I'll replace it with an old one that uses a loop or direct value by value copy and see where it gets me. I'll compare size for each too. I meant to bench mark those ages ago but never got around to it.

(0000159)
Fred (administrator)
2009-02-22 18:24

This is solved and pushed up, I'll close it once I figure out exactly why memcpy was screwing things up and post here about that.

Issue History
Date Modified	Username	Field	Change
2009-02-22 16:34	Fred	New Issue
2009-02-22 16:34	Fred	Status	new => assigned
2009-02-22 16:34	Fred	Assigned To	=> Fred
2009-02-22 16:34	Fred	Issue Type	=> Bug
2009-02-22 16:41	Fred	Note Added: 0000155
2009-02-22 16:52	Fred	Note Added: 0000156
2009-02-22 17:26	Fred	Note Added: 0000157
2009-02-22 17:48	Fred	Note Added: 0000158
2009-02-22 18:24	Fred	Note Added: 0000159

Notes
(0000155) Fred (administrator) 2009-02-22 16:41	The issue is with either my Nippon Denso code, OR the ignition or fuel code. I tried to reproduce the issue with Phil's 36-1 decoder and could not. Most likely the ignition PIT code is broken and corrupting memory. I will try to disable this next.

(0000156) Fred (administrator) 2009-02-22 16:52	Removing the ignition code did not help, I'll have to try removing the fuel code and putting ignition back. Then I'll remove both. If it still occurs then I'll look for the reason why it is happening in the remaining code. If that stops it I'll put a sleep function in to see if it is a sheer run time thing.

(0000157) Fred (administrator) 2009-02-22 17:26	Removal of fuel code didn't help either. ADC sampling is next to go.

(0000158) Fred (administrator) 2009-02-22 17:48	ADC sampling based on memcpy() is the cause!! I'll replace it with an old one that uses a loop or direct value by value copy and see where it gets me. I'll compare size for each too. I meant to bench mark those ages ago but never got around to it.

(0000159) Fred (administrator) 2009-02-22 18:24	This is solved and pushed up, I'll close it once I figure out exactly why memcpy was screwing things up and post here about that.

Relationships