|Anonymous | Login | Signup for a new account||2019-01-23 04:09 UTC|
|Main | My View | View Issues | Roadmap | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000871||Firmware||General Features||public||2013-10-15 20:07||2014-02-18 23:05|
|Target Version||0.2.1||Fixed in Version|
|Summary||0000871: Benchtest firmware fires(primes) all outputs (incl ignition) at power on|
|Description||When the S12 is powered, Fuel Pump prime is active and the outputs are primed 1 pulse including the ignition ports|
|Steps To Reproduce||Flash benchtest to targer, power on target|
|Additional Information||Fred is awesome|
|Tags||No tags attached.|
|Risk of Breakage||medium|
There is a lot of missing information in your report. None the less I had a look at the code and I did spot an issue with the priming of xgate controlled injectors. FYI if you are, you should not use xgate for ign control unless your have a very low RPM engine. There are software delays of a few micro-seconds. While these microseconds don't mean anything when it comes to fueling, the same is not true with ignition.
Author: Sean Keys <firstname.lastname@example.org>
Date: Tue Oct 15 20:46:00 2013 -0700
Fixed injector priming loop for XGATE controled injectors.
|Oh and thanks for filing a report :)|
There is no missing information from this report. Nevertheless, there is an error in it, there are no ignition pins in BenchTest, what he meant was that his ignition pins are *configured* as injectors in BenchTest, but, he's a user, I know that because I wrote it. Both your comments and commit are not relevant to this issue, whatsoever. However I did have a chuckle when I reviewed the commit, nice bug.
Given that hash is on a temp branch and will cease to exist, posted here for prosperity:
- XGOutputEvents.channelID = outputEventNumber;
+ XGOutputEvents.channelID = fixedConfigs1.schedulingSettings.xgateOutputChannel[outputEventNumber];
|Reopening, do NOT resolve issues that are NOT fixed!!!|
Yep, a bug introduced when I added the ability to change what XGATE channel you want associated to which output event channel.
"Reopening, do NOT resolve issues that are NOT fixed!!!" obviously
|Copyright © 2000 - 2011 MantisBT Group|