0000082: escaped bytes handled incorrectly causing checksum to be wrong.

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000082

[FreeEMS-Tuner] Comm Interface

minor

always

2008-12-03 00:09

2009-02-15 10:44

Reporter

Fred

View Status

public

Assigned To

Fred

Priority

normal

Resolution

fixed

Status

resolved

Product Version

Summary

0000082: escaped bytes handled incorrectly causing checksum to be wrong.

Description

I setup a test packet with 0 - 255 in it 8 times, when received, this is printed out :

2008-12-03 12:52:47,244 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,245 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,246 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,247 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,248 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,249 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,251 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,252 ERROR serial.FreeEMS_Vanilla - Wrongly escaped byte found in packet: 43
2008-12-03 12:52:47,254 ERROR comms.Serial - Checksum is incorrect! Provided: 55, generated: 151
Traceback (most recent call last):
  File "/home/fred/tuner/gui/__init__.py", line 130, in OnIdle
    self.CommsReceive()
  File "/home/fred/tuner/gui/__init__.py", line 312, in CommsReceive
    comms.getConnection().recieve()
  File "/home/fred/tuner/comms/Serial.py", line 171, in recieve
    logger.error('processRecieveBuffer failed to parse packet from buffer: %s' % join(protocols.toHex(cache)))
NameError: global name 'join' is not defined

Additional Information

This indicates to me that only one type of escaped byte is handled wrongly as there are 24 escaped bytes per test packet, 8 of each type.

Tags

No tags attached.

Issue Type

Bug

Attached Files

Relationships

Notes
(0000147) sry_not4sale (administrator) 2009-01-13 21:37	Packets were being escaped twice

(0000152) Fred (administrator) 2009-01-14 05:43	Tested fixed.

Issue History
Date Modified	Username	Field	Change
2008-12-03 00:09	Fred	New Issue
2008-12-03 00:09	Fred	Status	new => assigned
2008-12-03 00:09	Fred	Assigned To	=> sry_not4sale
2008-12-03 00:09	Fred	Issue Type	=> Bug
2009-01-13 21:37	sry_not4sale	Note Added: 0000147
2009-01-13 21:37	sry_not4sale	Status	assigned => resolved
2009-01-13 21:37	sry_not4sale	Resolution	open => fixed
2009-01-14 05:43	Fred	Note Added: 0000152
2009-01-14 05:43	Fred	Status	resolved => closed
2009-02-15 08:22	sry_not4sale	Status	closed => resolved
2009-02-15 08:22	sry_not4sale	Fixed in Version	=> 0.1
2009-02-15 08:23	sry_not4sale	Status	resolved => closed
2009-02-15 10:37	Fred	Status	closed => assigned
2009-02-15 10:37	Fred	Assigned To	sry_not4sale => Fred
2009-02-15 10:44	Fred	Status	assigned => resolved

Mantis 1.1.7[^]