0000811: Please add handling of 2d tables with arbitrary length.

(0002534)
Fred (administrator)
2013-01-17 22:38

Approved, this will be a generally useful addition for all users, as smaller 16 bit tables will be needed for various things too. This has a comment about it: http://issues.freeems.org/view.php?id=800#c2511 [^]

Though I described it in more detail elsewhere.

Basically as long as meta data matches, and type is 2d, and length is divisible by 4, you can simply cut it in half into axis and data and roll with it. Should be a very minor change to support this depending on how much hard coding and duplication there is.

(0002564)
sean94z (reporter)
2013-01-23 15:21

Hi mike, does this added json config entry look OK ? My 2d table is 32 value wide.

"MAF" : {
  "locationid" : "0x010E",
  "type" : "2D",
  "xtitle" : "voltage",
  "xcalc" : [{ "type":"div","value" : "0.0"}],
  "xdp" : "0",
  "xhighlight" : "voltage",
  "ytitle" : "Mass (g/s)",
  "ycalc" : [{ "type":"div","value" : "0.0"}],
  "ydp" : "2",
  "size" : "128"
}
},

(0002565)
sean94z (reporter)
2013-01-23 15:47

I get a size mismatch when I start the app.

#define TWODTABLEUS_MAF_LENGTH 32
/// This block used for 2d MAF
typedef struct {
    unsigned short Axis[TWODTABLEUS_MAF_LENGTH];
    unsigned short Values[TWODTABLEUS_MAF_LENGTH];
} twoDTableUSMAF;

/* TablesC small tables */
    case MAFVersusVoltageTableLocationID:
        details->size = sizeof(twoDTableUSMAF);
        details->RAMPage = RPAGE_TUNE_ONE;
        details->FlashPage = TUNETABLES_PPAGE;
        details->RAMAddress = (void*) &TablesC.SmallTablesC.MAFVersusVoltageTable;
        details->FlashAddress = MAFVersusVoltageTableLocation;
        details->parent = SmallTablesCLocationID;
        break;

(0002566)
sean94z (reporter)
2013-01-23 15:48

attached SS

(0002567)
sean94z (reporter)
2013-01-23 18:14

size = ((unsigned char)parsedPacket.payload[10]) << 8;
size += (unsigned char)parsedPacket.payload[11];

fixed that, now:

Creating new table view for location: 0x "10E"
TableView2D::passData "0x10E"
2D Table axis is out of order!

(0002568)
Fred (administrator)
2013-01-23 18:17

Well, is it?

(0002569)
sean94z (reporter)
2013-01-23 18:20

hmmmmmm, i figured it was *dummy. Let me properly populate my table and retry.

(0002570)
sean94z (reporter)
2013-01-23 18:43

Yep, it was my bunk table. Now I just need to file a table view bug that I just uncovered.

(0002588)
Fred (administrator)
2013-01-29 14:19

I presume this support was added and works?

(0002589)
Fred (administrator)
2013-01-29 14:20

Tested by Sean, hopefully. Close with hash or reopen, Sean.

(0002591)
sean94z (reporter)
2013-01-29 14:35

Works well, thx for the fast response.

Notes
(0002534) Fred (administrator) 2013-01-17 22:38	Approved, this will be a generally useful addition for all users, as smaller 16 bit tables will be needed for various things too. This has a comment about it: http://issues.freeems.org/view.php?id=800#c2511 [^] Though I described it in more detail elsewhere. Basically as long as meta data matches, and type is 2d, and length is divisible by 4, you can simply cut it in half into axis and data and roll with it. Should be a very minor change to support this depending on how much hard coding and duplication there is.

(0002564) sean94z (reporter) 2013-01-23 15:21	Hi mike, does this added json config entry look OK ? My 2d table is 32 value wide. "MAF" : { "locationid" : "0x010E", "type" : "2D", "xtitle" : "voltage", "xcalc" : [{ "type":"div","value" : "0.0"}], "xdp" : "0", "xhighlight" : "voltage", "ytitle" : "Mass (g/s)", "ycalc" : [{ "type":"div","value" : "0.0"}], "ydp" : "2", "size" : "128" } },

(0002565) sean94z (reporter) 2013-01-23 15:47	I get a size mismatch when I start the app. #define TWODTABLEUS_MAF_LENGTH 32 /// This block used for 2d MAF typedef struct { unsigned short Axis[TWODTABLEUS_MAF_LENGTH]; unsigned short Values[TWODTABLEUS_MAF_LENGTH]; } twoDTableUSMAF; /* TablesC small tables / case MAFVersusVoltageTableLocationID: details->size = sizeof(twoDTableUSMAF); details->RAMPage = RPAGE_TUNE_ONE; details->FlashPage = TUNETABLES_PPAGE; details->RAMAddress = (void) &TablesC.SmallTablesC.MAFVersusVoltageTable; details->FlashAddress = MAFVersusVoltageTableLocation; details->parent = SmallTablesCLocationID; break;

(0002566) sean94z (reporter) 2013-01-23 15:48	attached SS

(0002567) sean94z (reporter) 2013-01-23 18:14	size = ((unsigned char)parsedPacket.payload[10]) << 8; size += (unsigned char)parsedPacket.payload[11]; fixed that, now: Creating new table view for location: 0x "10E" TableView2D::passData "0x10E" 2D Table axis is out of order!

(0002568) Fred (administrator) 2013-01-23 18:17	Well, is it?

(0002569) sean94z (reporter) 2013-01-23 18:20	hmmmmmm, i figured it was *dummy. Let me properly populate my table and retry.

(0002570) sean94z (reporter) 2013-01-23 18:43	Yep, it was my bunk table. Now I just need to file a table view bug that I just uncovered.

(0002588) Fred (administrator) 2013-01-29 14:19	I presume this support was added and works?

(0002589) Fred (administrator) 2013-01-29 14:20	Tested by Sean, hopefully. Close with hash or reopen, Sean.

(0002591) sean94z (reporter) 2013-01-29 14:35	Works well, thx for the fast response.

Relationships