Mantis Bugtracker

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000071 [FreeEMS-Tuner] Firmware Protocol tweak always 2008-11-28 00:16 2009-02-15 08:27
Reporter Fred View Status public  
Assigned To sry_not4sale
Priority low Resolution fixed  
Status resolved   Product Version
Summary 0000071: firmware interface unique id is wrong and interface version is wrong
Description Currently :

protocols/FreeEMS_Vanilla/0_1.py

Should be :

protocols/IFreeEMS\ Vanilla/0.0.1.py

I think exact names are important as I could potentially use an underscore and mean for it to be different than a space. 0.0.1.py doesn't matter though, provided it has 3 digits. 0_0_1.py is fine too.
Additional Information
Tags No tags attached.
Issue Type Bug
Attached Files

- Relationships

-  Notes
(0000104)
sry_not4sale (administrator)
2008-11-28 07:58

Using spaces or dots or dashes in file names would break pythons import mechanism, so have renamed file to 0_0_1.py from 0_1.py
(0000105)
sry_not4sale (administrator)
2008-11-28 08:00

Fixed in commit 425b85e2264be44e02019394a361d1da18d6bdeb
(0000108)
Fred (administrator)
2008-11-28 13:49

Got the version change, but you missed the I on the front of IFreeEMS_Vanilla ;-)
(0000117)
Fred (administrator)
2008-11-30 12:16

Thinking about this some more...

I think what you need to do is either through config or in the master comms file have a mapping of exact string key identifier to file path and name. That way you can call them what you like and the id process will always work correctly. I think this is important and I hate spaced file names too :-)
(0000149)
sry_not4sale (administrator)
2009-01-13 21:43

Now moved to

/comms/protocols/IFreeEMS_Vanilla/0_0_1/*

- Issue History
Date Modified Username Field Change
2008-11-28 00:16 Fred New Issue
2008-11-28 00:16 Fred Status new => assigned
2008-11-28 00:16 Fred Assigned To => sry_not4sale
2008-11-28 00:16 Fred Issue Type => Bug
2008-11-28 07:58 sry_not4sale Note Added: 0000104
2008-11-28 08:00 sry_not4sale Note Added: 0000105
2008-11-28 08:00 sry_not4sale Status assigned => resolved
2008-11-28 08:00 sry_not4sale Resolution open => fixed
2008-11-28 13:49 Fred Note Added: 0000108
2008-11-28 13:49 Fred Status resolved => assigned
2008-11-28 13:49 Fred Resolution fixed => reopened
2008-11-30 12:16 Fred Note Added: 0000117
2009-01-13 21:43 sry_not4sale Note Added: 0000149
2009-02-15 08:27 sry_not4sale Status assigned => resolved
2009-02-15 08:27 sry_not4sale Fixed in Version => 0.1
2009-02-15 08:27 sry_not4sale Resolution reopened => fixed


Mantis 1.1.7[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker