Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000673LoaderGeneral Featurespublic2012-09-03 14:502012-09-03 20:26
ReporterFred 
Assigned ToFred 
PriorityimmediateSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformLinuxOSDebianOS VersionSid/Unstable
Product Version0.1.0-SNAPSHOT 
Target Version0.1.0Fixed in Version 
Summary0000673: Loader pays NO attention to user input
DescriptionClick:

connect
rip
have it fail
open file
connect
load

Starts fucking ripping.... uninspiring flakiness man :-(
TagsNo tags attached.
Issue TypeBug
Risk of Breakagevery high
Attached Files

- Relationships

-  Notes
User avatar (0001994)
sean94z (reporter)
2012-09-03 15:00

Alright, let me try to duplicate this.

When you say "have it fail", what are you doing to make it fail?
User avatar (0001995)
Fred (administrator)
2012-09-03 15:15

I spent the time to verify it. I reset the device while it was ripping.

(16:42:10) Fred: seank-efi: Loading...
(16:42:10) Fred: unable to verify serial monitor return code
(16:42:10) Fred: Error validating ACK from SMReadByteBlock
(16:42:10) Fred: Error validating sector at TODO implement retry
(16:42:10) Fred: Unable to load record set
(16:42:10) Fred: Failed To Load
(16:42:10) Fred: closing serial port

But yet:

Ripping...
unable to verify serial monitor return code
Error validating ACK from SMReadByteBlock
Failed To Rip
closing serial port

No TODO here. The retry code should be shared.

Your state machine needs work (bug and others like it in the past), as does the arch (TODO on one fail, not on others).
User avatar (0001996)
sean94z (reporter)
2012-09-03 15:27

Sorry I didn’t mean to say that you didn’t verify it. It's just faster sometimes if you give a step-by-step replay :-)


"
No TODO here. The retry code should be shared.

Your state machine needs work (bug and others like it in the past), as does the arch (TODO on one fail, not on others).
"

Agree, I really would like to implement a SMLib in the long run.

Let me see what I can get done :)
User avatar (0001998)
Fred (administrator)
2012-09-03 15:49

I wasn't offended, I was just pointing out that I did verify it, which I don't always do, so was very sure of it.

For now, just fix it.

I would strongly recommend that you implement your state machine in a unit testable and isolated way and include a full test suite with comments for each use case. Then you can KNOW that it works ;-)
User avatar (0001999)
Fred (administrator)
2012-09-03 15:50

However, the buttons should be tied directly to the actions. State machine is more about button state grey/not, etc. Hmmm.
User avatar (0002003)
Fred (administrator)
2012-09-03 18:55

Ripping...
Rip Successful!
Erasing...
Erase Successful!
Loading...
unable to verify serial monitor return code
Error did not receive ACK after writing a block
Unable to load record set
Failed To Load
closing serial port

FFS, it just tried to load after ripping :-/
User avatar (0002004)
sean94z (reporter)
2012-09-03 20:26

Please try:

commit bbef0a71f47a41cdd2eca237283db2fb42a11be8
Author: Sean Keys <skeys@ipdatasys.com>
Date: Mon Sep 3 13:15:27 2012 -0700

Thx


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker