Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000653OLVGeneral Featurespublic2012-08-15 15:252013-01-14 00:26
ReporterFred 
Assigned ToFred 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version0.0.3-SNAPSHOT 
Target Version0.0.3Fixed in Version0.0.3 
Summary0000653: Add about box
DescriptionFor non mac "help>about" to the right of existing menus. For mac, you need to do something special as described here:

http://java.sun.com/developer/technicalArticles/JavaLP/JavaToMac2/ [^]

Both about boxes should contain the same information and it should be populated through a single call in either case, or passed into the about handler/window/whatever at creation time.
Additional InformationPopulate with some hard coded basics which I'll expand upon later:

OpenLogViewer

Version: development-SNAPSHOT
Website: http://olv.diyefi.org [^]
Support: http://forum.diyefi.org/viewforum.php?f=32 [^]
Issues: http://issues.freeems.org [^]

Built by Maven 3
TagsNo tags attached.
Attached Files

- Relationships
related to 0000655closedBenFenner DIYEFI.org web Facilitate Mac OS X About box menu handeling. 

-  Notes
User avatar (0001902)
BenFenner (developer)
2012-08-17 21:20
edited on: 2012-08-17 21:22

The majority of this has been done from my end anyway. It is hard coded still, and needs the Mac style implemented, but the bones are there and good.
Screen shot: http://i.imgur.com/GxMJs.png [^]

Git hash: 889e15ce2b2b2c5fdd91a207d3524d20671c00c7

User avatar (0001903)
Fred (administrator)
2012-08-17 21:25

Do you want the good news or the bad news? OK, I've not run it and I CAN'T diff it, so there is no good news. Bad news: That commit can't go into the tree as is. It must be split. You've done file renames and refactoring and package moves with code change. Not acceptable, sorry.

FreeAir:OpenLogViewer fred$ git diff --stat 498144f..889e15c
 src/main/java/org/diyefi/openlogviewer/OpenLogViewer.java | 50 +++++--
 src/main/java/org/diyefi/openlogviewer/optionpanel/OptionFrameV2.java | 670 ----------------------------------------------------------------------------------------------
 src/main/java/org/diyefi/openlogviewer/propertypanel/PropertiesPane.java | 446 --------------------------------------------------------------
 src/main/java/org/diyefi/openlogviewer/propertypanel/SingleProperty.java | 133 -------------------
 src/main/java/org/diyefi/openlogviewer/subframes/AboutFrame.java | 121 +++++++++++++++++
 src/main/java/org/diyefi/openlogviewer/subframes/OptionsFrame.java | 669 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/main/java/org/diyefi/openlogviewer/subframes/PropertiesFrame.java | 446 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/main/java/org/diyefi/openlogviewer/subframes/SingleProperty.java | 133 +++++++++++++++++++
 src/main/resources/org/diyefi/openlogviewer/Labels.properties | 6 +
 src/main/resources/org/diyefi/openlogviewer/Labels_es.properties | 6 +
 10 files changed, 1422 insertions(+), 1258 deletions(-)

What really changed is much much much much less, and I need to be able to see it.
User avatar (0001904)
Fred (administrator)
2012-08-17 21:26

FYI, I have no problem with refactoring, but it must be done in a separate commit. As for messing with OptionPaneV2, that needs to be reverted, there is zero point inserting code change on something that will be deleted entirely soon.
User avatar (0001905)
BenFenner (developer)
2012-08-18 00:09

I'll clean it up.
User avatar (0001906)
Fred (administrator)
2012-08-18 00:17

It's possible to split a commit, though more work than undoing what you did and squashing the undo with the do into a "change only" commit, probably. Sorry for being a purist bastard, though diffability is a big deal IMO, and worth making a little fuss over.

Have a read here: http://forum.diyefi.org/viewtopic.php?f=41&t=1683 [^]

After you've read it, I'll add a bit to the formatting/white space section about refactoring/file renaming/etc, as it should have been in there all along. Thanks for pushing me to update it :-)
User avatar (0001907)
BenFenner (developer)
2012-08-21 13:35
edited on: 2012-08-21 14:06

This link may also be helpful for dealing with the Mac L&F.

https://developer.apple.com/library/mac/#documentation/Java/Conceptual/Java14Development/07-NativePlatformIntegration/NativePlatformIntegration.html [^]

Latest screen shot: http://i.imgur.com/Bkq4B.png [^]

Edit: This might help too? https://developer.apple.com/library/mac/#documentation/Java/Reference/Java_PropertiesRef/Articles/JavaSystemProperties.html#//apple_ref/doc/uid/TP40008047 [^]

User avatar (0001908)
BenFenner (developer)
2012-08-21 21:14

All done.

Git hash: 73e528421ef78f3230337acda92911aebae46732
User avatar (0001909)
Fred (administrator)
2012-08-21 22:37

Well done! Will close once I add the dep setup for it.
User avatar (0002526)
Fred (administrator)
2013-01-14 00:26

Fixed in 20ee832 or earlier.


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker