Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000611EMStudioUser Interfacepublic2012-07-12 10:372012-11-15 16:12
Assigned Tomalcom2073 
PlatformAllOSAllOS VersionAll
Product Version 
Target Version0.0.1Fixed in Version 
Summary0000611: Add current value highlighting to 2D and 3D curves
DescriptionBecause I know you're already working on some uber-simple meta-data...

Once you have that working and displaying the tables correctly the next logical thing would likely be to add tracers/current value highlights.

IE, on a 2D curve put a coloured dot and faint grey line through the axis location from the current data stream.

On 3D you'll have to highlight 1,2 or 4 cells with a border colour/thickness change. 1 if exactly on, 2 if exactly on one axis, which ever is closer darker, 4 with no axis exactly aligned (common case), which ever is closest in both directions gets darker highlighting.

I strongly suggest that you match on key. IE, if table has axis of IAT in *C and datalog has the same, then pair them automatically. This would be done at startup and used as is there after.

Keep in mind possible refresh of this stuff with datalog type/style change part way through an execution.
TagsNo tags attached.
Issue TypeNew Feature
Attached Files

- Relationships
has duplicate 0000602closedmalcom2073 Allow highlighting of active table cells 

-  Notes
User avatar (0001670)
BenFenner (updater)
2012-07-19 18:20

Make this optional (as always).
User avatar (0001671)
Fred (administrator)
2012-07-19 18:50

Give me a real world use case for having this turned off, then we'll discuss it being optional, or not.
User avatar (0001675)
BenFenner (updater)
2012-07-19 22:49
edited on: 2012-07-19 22:53

How does one give a use case for the disabling of a feature like this?
I don't want to see trails. Same reason I don't have mouse cursor trails on at the OS level. They are distracting to me. The value they add does not outweigh the distraction for me.

Edit: I don't think I'm reading this feature properly. "Tracer" got me confused. Ignore me for now.

User avatar (0001676)
BenFenner (updater)
2012-07-19 23:03
edited on: 2012-07-19 23:04

I believe I understand the request now, and in general I'm completely in favor of it. No need to disable it as long as it doesn't effect editing focus.

However, this feature is getting dangerously close to another feature that the tuner should have. I'm not sure if the two are compatible or not. Often they are merged.

The feature I'm talking about is having the table focus (to accept keyboard input) move from cell to cell with the ECU allowing quick changes with the keyboard. This style of feature obviously needs to be able to be turned on AND off.

Am I making sense?

User avatar (0001677)
Fred (administrator)
2012-07-19 23:36

Yes, I see your confusion, sorry for that! Thanks for clarifying! :-)

Both your additional edit follows engine, and gps style footprints/tracks require off/on and should be considered icing.
User avatar (0001709)
Fred (administrator)
2012-07-22 13:55

Updated title and description to be more clear.
User avatar (0001979)
Fred (administrator)
2012-08-30 14:46

Mike, a little video just for you and Ben, then delete: [^]
User avatar (0001980)
BenFenner (updater)
2012-08-30 15:12

Referencing the behavior in the video (likely unavailable for download by the time people read this). I like what I see. There are many ways to highlight the current cell(s). I'm used to the entire background color of the cell changing, but just having a border is fine with me.
Having the border(s) increase in intensity depending on how much weight that cell has at the moment is something I really like and have not seen before.

Overall I'm quite happy with the way it works.
User avatar (0001981)
Fred (administrator)
2012-08-30 15:14

Yep, the only other alternative to doing this is to show an exactly positioned dot, however that's not possible due to (probably) even cell sizes and potentially wild cell spacing. Thus this is the only want to do it *well* IMO. Mike said "you're not going to get smooth" and I think by that he means "I wanna use off the shelf widgets" which he'll have to not do, if he ever wants it to be truly world-class.
User avatar (0002369)
DeuceEFI (updater)
2012-10-28 16:38

Bump, to remind malcom2073 that this is important to people who are trying to tune their engines with EMStudio.
User avatar (0002371)
malcom2073 (manager)
2012-11-02 15:07

Well aware, it's near the top of my list, especially since I've got my own engine running :)
User avatar (0002389)
malcom2073 (manager)
2012-11-15 11:09

Implemented in 119170c2cce5fd389737c0e7f2514b7f0c5659a4.

I moved the priority of this up to 0.0.1, since I found it would be greatly helpful, especially during initial tuning. Will push this to dev once I'm happy with how it looks and operates, and also once I fix issue 0000759
User avatar (0002392)
Fred (administrator)
2012-11-15 16:12

0000758 should be your immediate priority above and beyond all other issues as all three branches are broken for a normal fw operation mode. It'd be good to get rid of the regression in 0000757 before adding more code/features, too.

Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker