Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000543TunixGeneral Featurespublic2012-03-25 00:562012-04-05 06:17
ReporterFred 
Assigned Todandruczyk 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version0.9.24-SNAPSHOT 
Target Version0.9.24Fixed in Version0.9.24-SNAPSHOT 
Summary0000543: Large Scale Code Duplication Present
Description6302de8..4c46e9e

src/plugins/freeems/freeems_tableio.c | 325 ++
src/plugins/freeems/freeems_tableio.h | 35 +
src/plugins/mscommon/mscommon_tableio.c | 324 ++
src/plugins/mscommon/mscommon_tableio.h | 35 +

Find a way to remove maintenance overhead and tendency to fix one of the copy pasted chunks and not the other by increasing plugin abstraction and sharing that code. No particular rush, but keep in mind, this is my issue, not yours, so do not close it just because it bothers you. Either ignore it or work on it - either is fine.

http://en.wikipedia.org/wiki/Duplicate_code#Problems_associated_with_duplicate_code [^]
TagsNo tags attached.
FirmwareVersion..................................................
Attached Files

- Relationships

-  Notes
(0001331)
dandruczyk (viewer)
2012-03-25 16:24

Fixed in ff2c6c0e9a1f90092df1e3a3befa19c530a1042a
User avatar (0001332)
Fred (administrator)
2012-03-25 16:26

Just reviewed the diff, looks great! Thank you very much, as always! :-)
User avatar (0001333)
Fred (administrator)
2012-03-25 16:31

Jeff, if you have some spare time soon and are running MTX to test other issue fixes, be sure to use this commit or later. Close if it's stable and the yaml stuff still works as it did. I expect it will.
User avatar (0001336)
ToxicGumbo (reporter)
2012-03-26 05:17

Fixed in hash ff2c6c0. Found no fault with table activity and YAML support.
User avatar (0001389)
Fred (administrator)
2012-04-05 00:56

Just re the attacks that I got because of this issue, please see 0000088 which refers to my own work and uses much the same language.
(0001390)
dandruczyk (viewer)
2012-04-05 06:17

stop with the salt, fred.....


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker