Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000510OLVGeneral Featurespublic2012-01-20 20:162012-08-14 16:27
ReporterFred 
Assigned ToFred 
PrioritynormalSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformLinuxOSDebianOS VersionSid/Unstable
Product Version0.0.3-SNAPSHOT 
Target Version0.0.3Fixed in Version0.0.3 
Summary0000510: Ctrl Q does not quit and Ctrl W does not close the last window (and effectively quit)
DescriptionW possibly doesn't close any windows. Without this I'm left with a vast ocean of events as I try to quit using the mouse...
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
User avatar (0001170)
BenFenner (developer)
2012-01-31 20:44

Ctrl+Q now quits the application (on all platforms for the moment, that might change).

Git hash: 4b9470325e8a4c2f216c9c3b6de3e1802cecc727

Still need to work on Ctrl+W
User avatar (0001742)
BenFenner (developer)
2012-07-26 16:41
edited on: 2012-07-26 16:52

Fred says that yes, Ctrl+W should close the currently active window of a program, but not the program itself unless the currently active window is the last window left (Windows and Linux). On MAC OSX I believe the behavior is slightly different. Even closing the last active window of an application on a Mac still leaves the application running.

Fred, does this sound right?

Also, Ctrl+Q is likely not behaving as expected. Right now (on Windows at least) it will close the application ONLY if you do the button combination with the main graph display window active. I do believe it should quit the application with ANY window active.

Fred, can you let me know if Ctrl+Q will quit the entire application if pressed while a window other than the main graph window is active (has focus)? If this works properly on Linux (and Mac?) I'd like to leave it at that and not emulate that behavior on Windows since it is not a Windows style approach.

User avatar (0001743)
Fred (administrator)
2012-07-26 16:45

Ben, the mac style guides often leave it up to the app because Apple understands that one set of behaviours is not always right for all apps. For OLV W will close current window, and will also kill app if that window is last. This is because it's invalid to have it exist without a window. We don't have and don't want a systray behaviour.
User avatar (0001744)
Fred (administrator)
2012-07-26 17:00

On Linux ctrl Q only exits from the main window, which I think is a normal and expected behaviour here, but maybe not on mac. Will test that now. On mac command Q gets you out in the main window or the chooser window, and ctrl Q gets you out in the main window. Quit is listed in the apple menu AND the file menu, which is slightly ugly. Nothing quits while inside a dialogue.
User avatar (0001745)
BenFenner (developer)
2012-07-26 17:10
edited on: 2012-08-10 14:20

I'm going to spell out expected behavior on Windows and spell out any deviation from that behavior in my testing. Fred, could do the same on Linux and Mac?
Add in Cmd+Q if appropriate?

Expected:
Ctrl+Q with main app window active - No action
Ctrl+Q with child app window active - No action
Ctrl+Q with file chooser window active - No action

Ctrl+W with main app window active - Close main app window AND app process
Ctrl+W with child app window active - Close active window BUT leave app process
Ctrl+W with file chooser window active - No action

Alt+F4 with main app window active - Close main app window AND app process
Alt+F4 with child app window active - Close active window BUT leave app process
Alt+F4 with file chooser window active - Close file chooser window BUT leave app process





Current deviation from expected:
Ctrl+Q with main app window active - Closes app and process. Should be no action.

Ctrl+W with main app window active - Does nothing.
Ctrl+W with child app window active - Does nothing.

User avatar (0001828)
Fred (administrator)
2012-08-06 20:53

See previous comment. Mac should have quit option removed from menu, ctrl q shouldn't do anything on mac either. Mac apple menu has quit built in which has cmd q and replaces the normal stuff from win/lin.
User avatar (0001829)
BenFenner (developer)
2012-08-06 21:31
edited on: 2012-08-07 12:34

Fred, check git hash : 83d94747f64b1c71717e0dbc18532e26893e5a6d

On the mac, the file menu option for "Quit" should no longer be there. Also make sure the typical mac full screen menu bar at the top still works and that there is no regression there. I changed OS detection for that to be independent of the Look and Feel.

User avatar (0001838)
Fred (administrator)
2012-08-11 00:12

control W works in linux, but control q no longer works. Please fix :-)
User avatar (0001873)
BenFenner (developer)
2012-08-13 18:24

Ctrl+W and Cmd+W should work appropriately on all OSes now. Ctrl+Q works on Linux again.
Check git hash: 58fcc3739d538551e5c90581823d9fddf3a79a03

The last thing to do is map Ctrl to Cmd on the Mac. Always. Correct?
User avatar (0001874)
Fred (administrator)
2012-08-13 18:27

Yes, but that's part of a diff issue iirc. Will test later today.
User avatar (0001875)
BenFenner (developer)
2012-08-13 18:36
edited on: 2012-08-14 16:19

Oh, okay. Great.

Edit: here it is 0000408

User avatar (0001877)
BenFenner (developer)
2012-08-13 23:17

Latest tweaks to make for Linux (only) key bindings:

Make sure Ctrl+Q only closes the main app window. Ctrl+W should close main app window and sub-windows. Right now they both do the same thing.
User avatar (0001878)
BenFenner (developer)
2012-08-14 15:20
edited on: 2012-08-14 16:04

Git hash: e788e5c36a605955678d66b751b883cea3f948b2

Ctrl+Q on Linux should now only close the main app window, and none of the sub-windows.

This issue should be resolved now. I'm marking it as such. If testing shows it is not, just re-open it.

User avatar (0001881)
BenFenner (developer)
2012-08-14 16:04
edited on: 2012-08-14 16:04

sean94z tested the latest (above) on Linux and said all is working as intended.

User avatar (0001882)
Fred (administrator)
2012-08-14 16:27

Works on Mac 10.6 and Deb on eee.


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker