Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000489OLVGeneral Featurespublic2011-12-27 11:122012-01-02 01:58
ReporterFred 
Assigned ToFred 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version0.0.3-SNAPSHOT 
Target Version0.0.3Fixed in Version0.0.3 
Summary0000489: Fix assorted ugliness in parts of the code that aren't about to get replaced.
DescriptionList of things that are not happy:

Restructure code with if then nothing style: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/graphing/GraphPositionPanel.html#116 [^]
Restructure weird for loop with increment in else block: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/graphing/MultiGraphLayeredPane.html#100 [^]
Restructure weird for loop with boolean inside, maybe to while: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/coloring/InitialLineColoring.html#76 [^]
Another i++ for loop to restructure: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/propertypanel/PropertiesPane.html#302 [^]

There was more, but they're in MarkedColor and OptionPaneV2 so I didn't bother listing them.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
User avatar (0001081)
BenFenner (developer)
2011-12-30 21:18

These small code quality issues should now be fixed to everyone's liking.
I hope.

Git hash: 5d048652b90925b5875b4294e5a0f08b4bd9a42e
User avatar (0001086)
Fred (administrator)
2011-12-30 21:53

Do you have time to build the docs "mvn site:site" and take a look at the results to confirm? That would be super helpful, pretty please :-)
User avatar (0001090)
Fred (administrator)
2012-01-02 01:58

Reviewed code, better now.


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker