| Anonymous | Login | Signup for a new account | 2021-01-18 19:57 UTC |  |
| Main | My View | View Issues | Roadmap | Repositories |
| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0000489 | OLV | General Features | public | 2011-12-27 11:12 | 2012-01-02 01:58 | ||||
| Reporter | Fred | ||||||||
| Assigned To | Fred | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | All | OS | All | OS Version | All | ||||
| Product Version | 0.0.3-SNAPSHOT | ||||||||
| Target Version | 0.0.3 | Fixed in Version | 0.0.3 | ||||||
| Summary | 0000489: Fix assorted ugliness in parts of the code that aren't about to get replaced. | ||||||||
| Description | List of things that are not happy: Restructure code with if then nothing style: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/graphing/GraphPositionPanel.html#116 [^] Restructure weird for loop with increment in else block: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/graphing/MultiGraphLayeredPane.html#100 [^] Restructure weird for loop with boolean inside, maybe to while: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/coloring/InitialLineColoring.html#76 [^] Another i++ for loop to restructure: http://olv.diyefi.org/site/releases/0.0.2/xref/org/diyefi/openlogviewer/propertypanel/PropertiesPane.html#302 [^] There was more, but they're in MarkedColor and OptionPaneV2 so I didn't bother listing them. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files | |||||||||
 Relationships |
|
 Relationships |
|
Notes |
|
 (0001081)BenFenner (developer) 2011-12-30 21:18 |
These small code quality issues should now be fixed to everyone's liking. I hope. Git hash: 5d048652b90925b5875b4294e5a0f08b4bd9a42e |
 (0001086)Fred (administrator) 2011-12-30 21:53 |
Do you have time to build the docs "mvn site:site" and take a look at the results to confirm? That would be super helpful, pretty please :-) |
|
(0001090) Fred (administrator) 2012-01-02 01:58 |
Reviewed code, better now. |
|
Notes |
| Copyright © 2000 - 2011 MantisBT Group |
 |