0000488: Probable math issue in graphing code.

(0001083)
BenFenner (developer)
2011-12-30 21:26

For now I am confident the code is performing exactly as expected. The two integers are divided with the result being rounded down to the nearest integer, and then the result is cast to a double. To expect anything else seems freshman to me?

Should I do something to make it clear that it is intended to work the way it works? O_o

I feel like I'm in the twilight zone a bit here.

(0001084)
BenFenner (developer)
2011-12-30 21:27

Okay, I see how it could be done clearer...

(0001085)
BenFenner (developer)
2011-12-30 21:30

And now I see that particular part of the code is actually not fully tested, and might not be right anyway. I'll test it more and fix it if need be, or make it clearer otherwise.

(0001087)
BenFenner (developer)
2011-12-30 21:57
edited on: 2011-12-30 21:59

It took a log file size of 512 bytes (4 records long) to highlight this bug, but you were right.

Fixed in git hash: 7d3c7a2fc0254851efddd193f6f0fcb403c63827

(0001088)
Fred (administrator)
2011-12-30 22:01

Correction: "Maven was right!" ;-) Seriously, you should run site:site from time to time and examine the results, other than the white space, which I'm going to politely ask you to clean up yourself before 0.0.3 goes out, it really does show you some nastiness in a nice automated way. There are lots of reports to dig through. The stuff I've not even mentioned yet is the "too complex" stuff. Some of it is mine, I'll be fixing that at some point soonish anyway, other bits are gufi's, those might get replaced, not sure if any of it is yours, but it pays to look at the metrics and code associated with bad numbers anyway IMO.

(0001089)
Fred (administrator)
2012-01-02 01:55

Reviewed code modification and am satisfied.

Notes
(0001083) BenFenner (developer) 2011-12-30 21:26	For now I am confident the code is performing exactly as expected. The two integers are divided with the result being rounded down to the nearest integer, and then the result is cast to a double. To expect anything else seems freshman to me? Should I do something to make it clear that it is intended to work the way it works? O_o I feel like I'm in the twilight zone a bit here.

(0001084) BenFenner (developer) 2011-12-30 21:27	Okay, I see how it could be done clearer...

(0001085) BenFenner (developer) 2011-12-30 21:30	And now I see that particular part of the code is actually not fully tested, and might not be right anyway. I'll test it more and fix it if need be, or make it clearer otherwise.

(0001087) BenFenner (developer) 2011-12-30 21:57 edited on: 2011-12-30 21:59	It took a log file size of 512 bytes (4 records long) to highlight this bug, but you were right. Fixed in git hash: 7d3c7a2fc0254851efddd193f6f0fcb403c63827

(0001088) Fred (administrator) 2011-12-30 22:01	Correction: "Maven was right!" ;-) Seriously, you should run site:site from time to time and examine the results, other than the white space, which I'm going to politely ask you to clean up yourself before 0.0.3 goes out, it really does show you some nastiness in a nice automated way. There are lots of reports to dig through. The stuff I've not even mentioned yet is the "too complex" stuff. Some of it is mine, I'll be fixing that at some point soonish anyway, other bits are gufi's, those might get replaced, not sure if any of it is yours, but it pays to look at the metrics and code associated with bad numbers anyway IMO.

(0001089) Fred (administrator) 2012-01-02 01:55	Reviewed code modification and am satisfied.

Relationships