Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000455TunixFreeEMS Pluginpublic2011-12-02 09:502012-03-30 20:32
ReporterFred 
Assigned ToFred 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version0.9.24-SNAPSHOT 
Target Version0.9.24Fixed in Version0.9.24 
Summary0000455: Bench Test Counter Ignores Errors
DescriptionThe counter starts running and disables/enables the buttons/fields even when a test doesn't start. Thus the stop fails too with a not running, or in the case of wrong firmware the same error that they start gave. It needs to:

 - Catch errors on initiation and don't set timer/change state
 - Catch errors on bump and not increment timer (I didn't check this, you may already)

Catching errors on stop and changing behaviour is probably incorrect, the only valid errors are "not running" due to a reset or mtx bug, or packet issues which shouldn't happen either really.

A bonus feature would be detecting reset via polling the datalog (if it's not running) and watching tempClock, or watching tempClock with it streaming. If you did that, and that should go in a separate issue I guess, then you could send a stop packet post reset to confirm that it's stopped (by listening for the not running error) and reset the state of the tab. This doesn't matter much, though.

In fact, this whole issue doesn't matter much, so leaving target blank, set it to whatever you want or leave it blank and ignore it for the time being :-)
TagsNo tags attached.
FirmwareVersionunknown, updating issue to appear in roadmap
Attached Files

- Relationships

-  Notes
(0000834)
dandruczyk (viewer)
2011-12-02 13:18

You need to provide ALL the INFO that causes a failed test... i.e. all values in the boxes, otherwise I cannot replicate.
User avatar (0000838)
Fred (administrator)
2011-12-02 13:41

Simple, load a non-bench test firmware and try to start a bench test with any values. Values weren't included because they're not relevant. The only wan you can trigger it to error AFAIK without that is to set the time per event to a value between 0 and 666 or the PWs between 3 and 666.
(0000849)
dandruczyk (viewer)
2011-12-02 17:43

Please re-test this. I don't have physical access, but the new chanegs should make this work properly. 1cefdb21546afe8541002f2089e6f4ae3bfa8cd3
User avatar (0000850)
Fred (administrator)
2011-12-02 17:51

Seems OK, but I think I found a bug in the firmware (or 2) now that this works, and can't confirm until I fix that/those. Will let you know how I get on.
User avatar (0000855)
Fred (administrator)
2011-12-02 18:59

Tested as fixed in Dave's latest as of now.


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker