|Anonymous | Login | Signup for a new account||2017-08-24 08:32 UTC|
|Main | My View | View Issues | Roadmap | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000289||Firmware||Init & Config||public||2011-10-07 16:36||2012-07-02 18:48|
|Target Version||0.2.0||Fixed in Version||0.2.0|
|Summary||0000289: Compile Time Scale All Constants & Defaults|
|Description||Migrate ignition advance angles to macros like this:|
BTDC(35.25) // to 0.25 degrees, but currently to 0.001 degrees
Rather than manually scaled values. This will also add a layer of portability to different scales as we are about to migrate.
Equally, migrate crank offset angles to the very similar:
CrankOffsetAngle(265.24) // to 0.02 degrees
Which can also check for angles of 720 degrees or over. Though this is possibly wasted effort as that is only temporary anyway.
Temperatures should be literal in one of the following three forms:
VE should be the same:
No literal initialisers should be left in the code. Add something to FreeTherm to do this too.
|Tags||No tags attached.|
|Risk of Breakage||very low|
|Put all of these, and the values that they rely upon, with docs, in one file.|
|The macros for these need to be slightly smart to give correct values. The default is to truncate such that 1.99999 = 1 and not 2. This is clearly wrong in small values. It's only slightly wrong in large values, but should be correct in all cases.|
|I did a LOT of work on this today, BUT, sadly, there was a power cut, and I didn't get to finish it of before bed. I'll nail it tomorrow and it will be wonderful.|
edited on: 2012-03-28 23:08
Fixed in 55fe830583c123cbae4d38f3f31cda82ef316fa2 please code review and close if satisfied. git pull;git diff HEAD^..HEAD or the same with git difftool.
|Jeff, i just force pushed, sorry! There was a tiny bit of dirtiness in one file... You can play spot the difference on the machine you already pulled to if you are curious :-)|
|Quite an overwhelming number of updates, many of which make the code more readable (and quite a bit of housekeeping). I didn't find anything inconsistent or incorrect when viewing the diffs. My American sensibilities, however, recommend changing DEGREES_C to DEGREES_F along with all associated values!|
|LOL, OK, I'll close it, then. Thanks for looking!|
|Copyright © 2000 - 2011 MantisBT Group|