Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000257FirmwareBuild Processpublic2011-09-07 19:302011-11-13 15:52
ReporterFred 
Assigned ToFred 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.2.0-SNAPSHOT 
Target Version0.2.0Fixed in Version0.2.0 
Summary0000257: Make Git Release Checking More Robust
DescriptionCurrently it does some checks on local hash and remote hash and so on, but not in the most careful way.

git show-ref --head HEAD

Should be used to grab whatever the head hash is, and that should be compared with some remote hash. We should possibly only allow release from master too, by comparing head of master with HEAD and branch name with "master".

Additionally, it would be nice if the build included the HEAD hash in the binary, and a compressed copy of a git diff --stat or similar. That way we can more or less find out what was on the card, even years later with no idea and it being a snapshot etc.

the fetch is done without args, we could specify origin or not. needs more thought.
TagsNo tags attached.
FirmwareVersion
Issue TypeBug
Risk of Breakagevery low
Attached Files

- Relationships

-  Notes
User avatar (0000522)
Fred (administrator)
2011-11-05 18:12

With the new auto versions this will require more work to reorder the actions such that the old release gets cleared out and committed before the tag is done and the new files are built and committed after the tag is done. It shouldn't be difficult to engineer this. Finally the firmware will be as well built as m2 projects!
User avatar (0000523)
Fred (administrator)
2011-11-05 18:15

This could be simplified quite a lot if I stop including firmware in the source, which is probably a good idea anyway...
User avatar (0000524)
Fred (administrator)
2011-11-05 23:46

Firmware is no longer in the source and this issue is solved. The only addition required other than restructuring was to check that we were on master before comparing master with origin. I also reordered the executions such that it fails faster in more cases. Lastly I split the release into release and package such that A the naming was correct and B packaging can be done at any time irrespective of release status. All available in 5aa3c8b885e1b0d620e64acfe13819ef2f5036a2
User avatar (0000575)
Fred (administrator)
2011-11-13 15:52

Add checking and early failure of build with message telling user that they are required to have git installed and available to build the firmware. Make it difficult to pull this out, if possible without dirtying the project.


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker