Mantis Bug Tracker

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000236LoaderGeneral Featurespublic2011-07-19 19:452012-08-27 21:12
ReporterFred 
Assigned ToFred 
PrioritynormalSeveritytextReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version0.1.0-SNAPSHOT 
Target Version0.1.0Fixed in Version 
Summary0000236: Tidy Up Source File Names
DescriptionCurrent file names are in bad taste, most start with variations on "freeems_loader"

Move most to unique names and keep one with the project name. Use consistent case, whatever it is, unlike this reporter whose sources are also a mess :-)
TagsNo tags attached.
Issue TypeBug
Risk of Breakagemedium
Attached Files

- Relationships

-  Notes
User avatar (0000370)
sean94z (reporter)
2011-10-10 18:54

Yeah "_" is only in good taste when it comes to macro names IMO.
User avatar (0000371)
Fred (administrator)
2011-10-10 19:15

Pretty much, however the main complaint was that they all start with the same thing. They should not contain common prefix, if they really should, put them in a directory instead and remove it. Make sense? :-)
User avatar (0000372)
sean94z (reporter)
2011-10-10 19:16

yep! thx
User avatar (0000378)
sean94z (reporter)
2011-10-11 23:23

names revised, please advise.
User avatar (0000471)
sean94z (reporter)
2011-10-24 21:38

review file names since commit f5627738cac3a3dc06dda087a1d0b761aacd7411
User avatar (0000480)
Fred (administrator)
2011-10-24 23:11

Reopening as there are still 4 files in a fresh checkout with basically the same name, but not quite, which should be the same, and without underscore. Plus I just grepped and only the names changed, the classes are all still the same as before :-) Nice try! I like the file names though, except for:

freeems_loader.cpp
freeems_loader.ui
FreeEMS_Loader.iss
FreeEMS_Loader.pro

how about freeems-loader.* ? or even freeemsLoader.* or even freeEmsLoader.* ?

Probably freeems-loader.* is best with a corresponding executable name. Is the windows exe able to be named differently easily? If so I'd call that one "FreeEMS Loader.exe" with a space, if that's legit on windows. Just so that it's pretty in a win gui :-)
User avatar (0001925)
sean94z (reporter)
2012-08-27 21:12

Please review:

commit a0e0281df1dcc2f43304214404a135ce10142e5d
Author: Sean Keys <skeys@ipdatasys.com>
Date: Mon Aug 27 14:11:03 2012 -0700

    [0000236] Renamed files in an attempt to satisfy 'better' files names.


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker