FreeEMS Issues - OLV
View Issue Details
0000833OLVGeneral Featurespublic2013-03-13 13:002013-03-13 13:36
BenFenner 
Fred 
normalmajoralways
assignedopen 
AllAllAll
0.0.3-SNAPSHOT 
0.0.3 
0000833: MegaSquirt and Adaptronic CSV data logs contain non-numeric data, and we don't handle it well.
Another user and I separately encountered the same issue last night while attempting to load two different logs (one from MegaSquirt and one from Adaptronic).

When attempting to open the log, the log silently fails to open.

This seems to be due to non-numeric data that is present in the logs. Once removed, they opened fine.

Example of non-numeric data:


Synched,
NO,
NO,
NO,
YES,
YES,
YES
No tags attached.

Notes
(0002616)
BenFenner   
2013-03-13 13:04   
We have four options IMO. Possibly moving from one solution to another as dev time permits.

1) We can detect the issue and reject loading the log with a notice to the user.
2) We can load the log but ignore the numeric data and notify the user of this.
3) We can dynamically convert the non-numeric data to numeric data and notify the user of the change.
4) We can update OLV to handle non-numeric data properly, somehow.
(0002617)
Fred   
2013-03-13 13:11   
We can add a ms specific log parser, too. It would be legitimate to convert YES to 1 and NO to 0 in that.
(0002618)
Fred   
2013-03-13 13:12   
However it should currently fail, and isn't. That should be addressed too.