FreeEMS Issues - OLV
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000683OLVGeneral Featurespublic2012-09-09 11:222012-09-11 13:10
ReporterFred 
Assigned ToBenFenner 
PrioritylowSeveritytweakReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version0.0.3-SNAPSHOT 
Target Version0.0.3Fixed in Version0.0.3 
Summary0000683: Unit tests not robust across borders
DescriptionInternational borders, that is. Ideally you should use a system provided separator, however it might be overkill for a set of tests ;-)

(13:01:26) struberg: Failed tests: testRoundDecimalPlaces(org.diyefi.openlogviewer.utils.MathUtilsTest): expected:<.......> but was:<...,...>
Steps To ReproduceSet locale to one that uses , not . to separate decimals then run mvn test
Additional Information
TagsNo tags attached.
Relationships
Attached Files

Notes
(0002092)
Fred   
2012-09-10 20:09   
Just realised that you can probably set the locale to US-EN before running the test, and that'll solve it.
(0002093)
BenFenner   
2012-09-10 20:16   
Changing target version from "Future" to "0.0.3" since this should be easy to fix and it causes issues with building when unit tests fail.
(0002105)
Fred   
2012-09-11 12:19   
Was feeling impatient, fixed in: fca0346 close if happy. Be happy by changing to FRANCE to cause failure.
(0002108)
BenFenner   
2012-09-11 13:10   
Switching to Locale.FRANCE caused the tests to fail. So that's good.

Switching default locale (without switching it back) in the tests doesn't affect the main app either in Eclipse or in Maven since they don't re-use JVM instances between the tests and the main app.