FreeEMS Issues - OLV
View Issue Details
0000636OLVGeneral Featurespublic2012-07-31 17:472012-08-22 21:16
BenFenner 
Fred 
normalminorN/A
closedfixed 
AllAllAll
0.0.3-SNAPSHOT 
0.0.30.0.3 
0000636: Pre-0.0.3 release code clean-up using mvn site.
Make Fred happy.
No tags attached.
parent of 0000642closed Fred Full code review 

Notes
(0001831)
Fred   
2012-08-07 23:09   
A few points:

1) Leave whitespace/formatting changes till last.
2) Don't change optionpanev2 at all, it's going to be gone soon, waste of repo space to do so
3) Any non-cosmetic changes should be very carefully checked. Get someone else in IRC to help you test it, direct them on what to try, use temp branches if unsure.
4) Don't mess with FreeEMSBin at all

See these reports:

findbugs - case by case
checkstyle - not just style in here, last release was 383, last hash i pulled has 449, aim for under 300. do this last
javancss - review stuff with high CCN numbers
cpd - consider breaking out common chunks into sub-methods
pmd - likely mostly bogus, perhaps we can configure this to be less zealous or more specific
jdepend - review this, try to understand why it defines OLV code as bad code, refactor stuff if you feel like it

consider upping the effort and lowering the threshold on findbugs to draw out more issues.
(0001876)
BenFenner   
2012-08-13 18:46   
(edited on: 2012-08-13 18:52)
A good bit of this has been completed.
A little bit of CCN (high complexity) was fixed.
A couple bugs found by the bug finder were fixed.
Style points went from 383 at 0.0.2 release to 488 when I started doing the cleanup and it is at 300 now.

I'm halting work on this until the rest of 0.0.3 is completed and it is time to check this stuff again.
The git hash with the changes from this update is: 2523f54ee50532f5793460b89749edeab8697ac2

(0001912)
BenFenner   
2012-08-22 20:45   
Work completed in git hash: 462aecc306d6f73452c5c2487518863e5c1ed7b4

Much better code reuse for NavBarPanel.java. Also remove superfluous use of 'this'.

Checkstyle error count after last wave was 300, after doing more real work it crept up to 329 and now after this second and final wave of clean-up it is down to 260. The release of 0.0.3 is not far away now. =D
(0001913)
Fred   
2012-08-22 21:16   
Reviewed diff, looked good. Checked app too, looks good!