FreeEMS Issues - Tunix
View Issue Details
0000543TunixGeneral Featurespublic2012-03-25 00:562012-04-05 06:17
Fred 
dandruczyk 
normalminorN/A
closedfixed 
AllAllAll
0.9.24-SNAPSHOT 
0.9.240.9.24-SNAPSHOT 
..................................................
0000543: Large Scale Code Duplication Present
6302de8..4c46e9e

src/plugins/freeems/freeems_tableio.c | 325 ++
src/plugins/freeems/freeems_tableio.h | 35 +
src/plugins/mscommon/mscommon_tableio.c | 324 ++
src/plugins/mscommon/mscommon_tableio.h | 35 +

Find a way to remove maintenance overhead and tendency to fix one of the copy pasted chunks and not the other by increasing plugin abstraction and sharing that code. No particular rush, but keep in mind, this is my issue, not yours, so do not close it just because it bothers you. Either ignore it or work on it - either is fine.

http://en.wikipedia.org/wiki/Duplicate_code#Problems_associated_with_duplicate_code [^]
No tags attached.

Notes
(0001331)
dandruczyk   
2012-03-25 16:24   
Fixed in ff2c6c0e9a1f90092df1e3a3befa19c530a1042a
(0001332)
Fred   
2012-03-25 16:26   
Just reviewed the diff, looks great! Thank you very much, as always! :-)
(0001333)
Fred   
2012-03-25 16:31   
Jeff, if you have some spare time soon and are running MTX to test other issue fixes, be sure to use this commit or later. Close if it's stable and the yaml stuff still works as it did. I expect it will.
(0001336)
ToxicGumbo   
2012-03-26 05:17   
Fixed in hash ff2c6c0. Found no fault with table activity and YAML support.
(0001389)
Fred   
2012-04-05 00:56   
Just re the attacks that I got because of this issue, please see 0000088 which refers to my own work and uses much the same language.
(0001390)
dandruczyk   
2012-04-05 06:17   
stop with the salt, fred.....