FreeEMS Issues - OLV
View Issue Details
0000492OLVUser Interfacepublic2012-01-01 21:322012-01-12 17:44
0000492: All zero traces hang at top.
It would be better if traces with only one value were at the bottom of the division graph area, or something more sophisticated?

Ideally <= 0 == bottom and > 0 == top.

I don't know when this changed, but having all zeros is common and having them appear at the top is misleading IMO and distracting from more interesting data.
No tags attached.

2012-01-09 17:07   
I don't when this changed either. I can't even begin to imagine why it changed. I'll look into it.
2012-01-09 21:24   
(edited on: 2012-01-09 21:29)
There are two things going on here conspiring to cause the problem. First, if the minimum and maximum values (the vertical window you want to view of the trace) are set equal then this behavior is shown. For the traces where the data points are all zeros, the min/max values seem to be set to 0/0 respectively by default. So that's causing the main problem.
The other problem is exactly what behavior we'd like to see when max/min are equal. Do we want that to be possible? if so, do we want the trace at the "bottom" or maybe in the middle?

I'm going to fix things so they make more sense and provide sane behavior, but maybe we want to delve into this a bit more.

2012-01-09 21:41   
This poor behavior is fixed.

Git hash: c5a00b91ddb8047d133bcaf4975f3a3d46f850d3
2012-01-09 22:39   
I hope you went with bottom, if not, please do that, as putting them through the middle is just annoying and obscures the view when in the normal case they are all zero. I'll play with it tomorrow after I unpack and setup my fancy new desk and test rig etc.
2012-01-10 00:01   
Oh yes, they are back at the bottom now.
2012-01-12 17:44   
Tested fixed!