FreeEMS Issues - Loader
View Issue Details
0000395LoaderGeneral Featurespublic2011-11-16 12:342012-09-11 17:15
Fred 
Fred 
normalminoralways
resolvedfixed 
LinuxDebianSid/Unstable
0.1.0-SNAPSHOT 
0.1.0 
Improvement
medium
0000395: Internal State Not Cleared After Disconnect
The S19 that was previously loaded should be removed such that post disconnect you have to re-choose and re-parse a file. Otherwise the load button is still enabled and it's easy to forget to select a new file. Given that loading the same file twice is something that should never need to be done, I think this is easily the best practice.
No tags attached.

Notes
(0002005)
sean94z   
2012-09-03 20:28   
oops sorry issue has not been resolved via

commit bbef0a71f47a41cdd2eca237283db2fb42a11be8
Author: Sean Keys <skeys@ipdatasys.com>
Date: Mon Sep 3 13:15:27 2012 -0700
(0002086)
sean94z   
2012-09-10 19:41   
"Given that loading the same file twice is something that should never need to be done"

According to that logic, you should have to reload another S19 at that point as well right ?

post disconnect | post loadComplete = drop current s19, forcing user to load another.

?
(0002088)
Fred   
2012-09-10 19:56   
Yeah, for a successful load, yes. For a fail, no, retry with same is fine. Make sense? Remembering file and dir takes care of repeated loads, click, hit enter a few times, etc.
(0002113)
sean94z   
2012-09-11 14:21   
Please try:

commit 2b10b75b855271a53ae53252108598b2b231cfa2
Author: Sean Keys <skeys@ipdatasys.com>
Date: Tue Sep 11 07:17:54 2012 -0700

    [0000395] Loader now requires you to reload an s19 file after a sucessful load or disconnect.

Thx!
(0002114)
sean94z   
2012-09-11 17:15   
Sorry please make that commit:

commit c2001596ee96b1ea9dfde071c065903414117b23
Author: Sean Keys <skeys@ipdatasys.com>
Date: Tue Sep 11 10:14:58 2012 -0700

    forgot to include with with fix [0000395]